From f6d0dcf38dcd42921da593acb8f9a51c87cfab02 Mon Sep 17 00:00:00 2001
From: silverpill <silverpill@firemail.cc>
Date: Mon, 14 Aug 2023 01:21:05 +0000
Subject: [PATCH] FEP-c390: Use new cryptosuite name

- Replaced jcs-eddsa-2022 cryptosuite with eddsa-jcs-2022 in examples.
- Added implementation notes.
- Updated links to Data Integrity spec.
- Updated implementation links.
---
 fep/c390/fep-c390.feature |  8 ++++----
 fep/c390/fep-c390.md      | 14 +++++++++-----
 2 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/fep/c390/fep-c390.feature b/fep/c390/fep-c390.feature
index 0c82e61..4c06b67 100644
--- a/fep/c390/fep-c390.feature
+++ b/fep/c390/fep-c390.feature
@@ -23,11 +23,11 @@ Feature: FEP-c390: Identity Proofs
                 "alsoKnownAs": "https://server.example/users/alice",
                 "proof": {
                     "type": "DataIntegrityProof",
-                    "cryptosuite": "jcs-eddsa-2022",
+                    "cryptosuite": "eddsa-jcs-2022",
                     "created": "2023-02-24T23:36:38Z",
                     "verificationMethod": "did:key:z6MkrJVnaZkeFzdQyMZu1cgjg7k1pZZ6pvBQ7XJPt4swbTQ2",
                     "proofPurpose": "assertionMethod",
-                    "proofValue": "zYqr4eFzrnUWiBDaa7SmBhfaSBiv6BFRsDRGkmaCJpXArPBspFWNM6NXu77R7JakdzbUdjZihBa28LuWscZxSfRk"
+                    "proofValue": "z26W7TfJYD9DrGqnem245zNbeCbTwjb8avpduzi1JPhFrwML99CpP6gGXSKSXAcQdpGFBXF4kx7VwtXKhu7VDZJ54"
                 }
             }
             """
@@ -58,11 +58,11 @@ Feature: FEP-c390: Identity Proofs
                         "alsoKnownAs": "https://server.example/users/alice",
                         "proof": {
                             "type": "DataIntegrityProof",
-                            "cryptosuite": "jcs-eddsa-2022",
+                            "cryptosuite": "eddsa-jcs-2022",
                             "created": "2023-02-24T23:36:38Z",
                             "verificationMethod": "did:key:z6MkrJVnaZkeFzdQyMZu1cgjg7k1pZZ6pvBQ7XJPt4swbTQ2",
                             "proofPurpose": "assertionMethod",
-                            "proofValue": "zYqr4eFzrnUWiBDaa7SmBhfaSBiv6BFRsDRGkmaCJpXArPBspFWNM6NXu77R7JakdzbUdjZihBa28LuWscZxSfRk"
+                            "proofValue": "z26W7TfJYD9DrGqnem245zNbeCbTwjb8avpduzi1JPhFrwML99CpP6gGXSKSXAcQdpGFBXF4kx7VwtXKhu7VDZJ54"
                         }
                     }
                 ]
diff --git a/fep/c390/fep-c390.md b/fep/c390/fep-c390.md
index 55c6338..09d7583 100644
--- a/fep/c390/fep-c390.md
+++ b/fep/c390/fep-c390.md
@@ -40,7 +40,7 @@ The identity proof document MUST contain a data integrity proof, which includes
 
 The resulting data integrity proof MUST be added to identity proof document under the `proof` key.
 
-Example:
+Example of an actor object linked to `did:key` identifier:
 
 ```json
 {
@@ -65,11 +65,11 @@ Example:
             "alsoKnownAs": "https://server.example/users/alice",
             "proof": {
                 "type": "DataIntegrityProof",
-                "cryptosuite": "jcs-eddsa-2022",
+                "cryptosuite": "eddsa-jcs-2022",
                 "created": "2023-02-24T23:36:38Z",
                 "verificationMethod": "did:key:z6MkrJVnaZkeFzdQyMZu1cgjg7k1pZZ6pvBQ7XJPt4swbTQ2",
                 "proofPurpose": "assertionMethod",
-                "proofValue": "zYqr4eFzrnUWiBDaa7SmBhfaSBiv6BFRsDRGkmaCJpXArPBspFWNM6NXu77R7JakdzbUdjZihBa28LuWscZxSfRk"
+                "proofValue": "z26W7TfJYD9DrGqnem245zNbeCbTwjb8avpduzi1JPhFrwML99CpP6gGXSKSXAcQdpGFBXF4kx7VwtXKhu7VDZJ54"
             }
         }
     ]
@@ -80,7 +80,7 @@ Example:
 
 The consuming implementations MUST check the authenticity of identity proof document by verifying its data integrity proof. If the proof can not be verified, or if the value of `verificationMethod` property of the data integrity proof doesn't match the value of `subject` property of the identity proof, or if the value of `alsoKnownAs` property of the identity proof doesn't match the actor ID, the identity proof MUST be discarded.
 
-Verification process MUST follow the *Data Integrity* specification, section [4.2 Verify Proof](https://w3c.github.io/vc-data-integrity/#verify-proof).
+Verification process MUST follow the *Data Integrity* specification, section [4.3 Verify Proof](https://w3c.github.io/vc-data-integrity/#verify-proof).
 
 ### Linking identities
 
@@ -88,13 +88,17 @@ The consuming implementations SHOULD treat identities denoted by `subject` and `
 
 If two actors have identity proofs with the same `subject` property, they SHOULD be treated as different identities of the same entity.
 
+### Implementation notes
+
+Servers MUST present identity proofs to clients in their original form. Clients MAY perform independent verification of identity proofs if needed.
+
 ## Test vectors
 
 See [fep-c390.feature](./fep-c390.feature)
 
 ## Implementations
 
-- [Mitra](https://codeberg.org/silverpill/mitra/src/commit/eb18e475efb71e461cd33c800c86cfe94144f5a3/FEDERATION.md#identity-proofs)
+- [Mitra](https://codeberg.org/silverpill/mitra/src/commit/71db89f0ac323c76b7e08efffacf5d2454ec9afc/FEDERATION.md#identity-proofs)
 
 ## References