This is my first FEP and first time writing a technical document of this style, so any and all feedback is appreciated.
This FEP is for the most part due to my personal project [Shoot](https://github.com/MaddyUnderStars/shoot/), an activitypub federated instant messenger. It's much like Discord and I needed a method of joining 'servers' via an invite code.
My concerns currently are:
- I'm aware of the use of Invite activities in [Forte](https://codeberg.org/fortified/forte/src/branch/dev/FEDERATION.md#events) and in [Smithereen](https://smithereen.software/docs/federation/groups) and I believe this FEP doesn't conflict with their usage, however there may be other software that does conflict with this
- I'm not sure if I am a fan of using webfinger to resolve Invite activities. This isn't for any real reason, it just feels wrong.
Let me know if you'd like me to create a discussion post about this somewhere. I see a few different FEPs have tracking issues here for discussion while some others have socialhub posts. Is this personal preference?
Co-authored-by: MaddyUnderStars <46743919+MaddyUnderStars@users.noreply.github.com>
Reviewed-on: https://codeberg.org/fediverse/fep/pulls/852
- Removed unnecessary section about `history` property.
- Converted "Compatibility with Conversation Containers" section into a NOTE.
- Added tootik and Lemmy to implementations
Reviewed-on: https://codeberg.org/fediverse/fep/pulls/853
- Added "Counting voters" section explaining the purpose of `votersCount` property.
- Added "Limits" section with Mastodon's poll option limit.
- Removed `MUST` requirement from the description of anonymous poll.
- Added "Closing a poll" section.
- Added link to `Question` JSON schema.
Reviewed-on: https://codeberg.org/fediverse/fep/pulls/842
- Explained why actor isolation is a necessary assumption.
- Removed similar but poorly worded explanation from the "Origin" section.
- Discouraged the use of partially embedded objects.
- Listed the properties that are used to specify intended audience.
- Explained why access control on public objects doesn't work.
- Removed requirement to use duck typing (temporarily).
- Added requirement to check authorization on embedded activities.
Reviewed-on: https://codeberg.org/fediverse/fep/pulls/849
- Adding NodeBB into list of implementations 🍪
- Add {audience} token to `Create` intent
- Add {context} token to `Create` intent
- Add better examples and description for using `Create` intents
Reviewed-on: https://codeberg.org/fediverse/fep/pulls/845
I added an extra section "Dormant" to the document. I consider myself dormant, where after creating this repo I have been very active for a long time, but currently only do a fly-by action where that's helpful, like a PR review approval, participation on SocialHub, and pointing to FEP resources on various channels (i.e. "weaving in public").
Also I added the originators of the FEP process, Corry Slep and Pukkamustard with their SocialHub account as reference, for people who wanna do a search in forum archives.
Reviewed-on: https://codeberg.org/fediverse/fep/pulls/818
Reviewed-by: silverpill <silverpill@noreply.codeberg.org>
- Clarified use cases in summary.
- Fragments should not contain integrity proofs.
- Unsupported algorithms should be ignored (forward compatibility).
- Added note about repudiability.
Reviewed-on: https://codeberg.org/fediverse/fep/pulls/839
silverpill
silverpill
Madeline
devnull
Ben Pate
Arnold Schrijver
Steve Bate
Lynn Foster
Matthias Pfefferle
Marcin Czachurski
mkljczk
ClearlyClaire